A magnesium phenate is prepared by a process which comprises reacting (1) magnesium oxide, magnesium hydroxide, magnesium carbonate, magnesium bicarbonate or a magnesium carboxylate with (2) a phenol, a methylene bis-phenol or a sulphurised phenol in the presence of (3) a solvent comprising an organic compound containing one or more alcoholic hydroxyl groups e.g. an alkoxy alcohol and (4) a promoter selected from a ketone, diketone such as α or β diketone, aldehyde or carboxylic acid and (5) optionally a diluent oil. This magnesium phenate may be used as a detergent for a lubricating oil.